Bug 144567

Summary: Move ReadableStreamJSSource.h/.cpp to ReadableJSStream.h/.cpp
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebasing for landing none

youenn fablet
Reported 2015-05-04 06:00:07 PDT
We should refactor ReadableStreamJSSource.cpp/.h and rename those files ReadableJSStream.h/.cpp. As part of this refactoring, ReadableStreamJSSource should be moved to ReadableStreamJS::Source.
Attachments
Patch (32.74 KB, patch)
2015-05-04 07:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing for landing (33.42 KB, patch)
2015-05-06 03:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-05-04 07:06:48 PDT
Created attachment 252308 [details] Patch
Darin Adler
Comment 2 2015-05-05 09:10:41 PDT
Comment on attachment 252308 [details] Patch Did you use the do-webcore-rename script to do this rename? It’s pretty good at it.
youenn fablet
Comment 3 2015-05-05 11:55:51 PDT
(In reply to comment #2) > Comment on attachment 252308 [details] > Patch > > Did you use the do-webcore-rename script to do this rename? It’s pretty good > at it. Thanks for mentioning this, I was not aware of it. I will give it a try next time I need it.
youenn fablet
Comment 4 2015-05-06 03:38:16 PDT
Created attachment 252466 [details] Rebasing for landing
WebKit Commit Bot
Comment 5 2015-05-06 05:01:02 PDT
Comment on attachment 252466 [details] Rebasing for landing Clearing flags on attachment: 252466 Committed r183866: <http://trac.webkit.org/changeset/183866>
WebKit Commit Bot
Comment 6 2015-05-06 05:01:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.