Bug 144567 - Move ReadableStreamJSSource.h/.cpp to ReadableJSStream.h/.cpp
Summary: Move ReadableStreamJSSource.h/.cpp to ReadableJSStream.h/.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 06:00 PDT by youenn fablet
Modified: 2015-05-06 05:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (32.74 KB, patch)
2015-05-04 07:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing for landing (33.42 KB, patch)
2015-05-06 03:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-05-04 06:00:07 PDT 
We should refactor ReadableStreamJSSource.cpp/.h and rename those files ReadableJSStream.h/.cpp.
As part of this refactoring, ReadableStreamJSSource should be moved to ReadableStreamJS::Source.
Comment 1 youenn fablet 2015-05-04 07:06:48 PDT 
Created attachment 252308 [details]
Patch
Comment 2 Darin Adler 2015-05-05 09:10:41 PDT 
Comment on attachment 252308 [details]
Patch

Did you use the do-webcore-rename script to do this rename? It’s pretty good at it.
Comment 3 youenn fablet 2015-05-05 11:55:51 PDT 
(In reply to comment #2)
> Comment on attachment 252308 [details]
> Patch
> 
> Did you use the do-webcore-rename script to do this rename? It’s pretty good
> at it.

Thanks for mentioning this, I was not aware of it.
I will give it a try next time I need it.
Comment 4 youenn fablet 2015-05-06 03:38:16 PDT 
Created attachment 252466 [details]
Rebasing for landing
Comment 5 WebKit Commit Bot 2015-05-06 05:01:02 PDT 
Comment on attachment 252466 [details]
Rebasing for landing

Clearing flags on attachment: 252466

Committed r183866: <http://trac.webkit.org/changeset/183866>
Comment 6 WebKit Commit Bot 2015-05-06 05:01:06 PDT 
All reviewed patches have been landed.  Closing bug.