Bug 144559

Summary: [GTK] [Stable] DrawingBuffer.h used outside of include guard
Product: WebKit Reporter: Philip Chimento <philip.chimento>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: cgarcia, clopez, commit-queue, mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.10   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
Patch that fixes the problem
none
Patch that fixes the problem cgarcia: review+

Philip Chimento
Reported 2015-05-03 16:59:20 PDT
Here's a patch that fixes a header used outside of an include guard, causing the build to break if that feature wasn't enabled.
Attachments
Patch that fixes the problem (433 bytes, patch)
2015-05-03 17:01 PDT, Philip Chimento 		no flags
DetailsFormatted DiffDiff
Patch that fixes the problem (1.25 KB, patch)
2015-05-07 21:58 PDT, Philip Chimento 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philip Chimento
Comment 1 2015-05-03 17:01:05 PDT
Created attachment 252293 [details] Patch that fixes the problem
WebKit Commit Bot
Comment 2 2015-05-03 17:03:54 PDT
Attachment 252293 [details] did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2015-05-04 08:18:34 PDT
This file was removed from trunk - http://trac.webkit.org/changeset/181468 (Additionally the changelog is missing.) Do you want to push this patch to a GTK release version?
Philip Chimento
Comment 4 2015-05-07 21:58:44 PDT
Created attachment 252683 [details] Patch that fixes the problem Yes, this patch was for 2.8.0. If it's not valid on master anymore, then I'll propose it for inclusion in https://trac.webkit.org/wiki/WebKitGTK/2.8.x . Here's an updated patch with changelog.
Philip Chimento
Comment 5 2015-05-10 11:45:47 PDT
Confirmed that this patch is not needed for master.
Carlos Alberto Lopez Perez
Comment 6 2015-06-10 12:16:33 PDT
I confirm this patch is needed for the 2.8 stable series. Should be included in 2.8.4 Thanks
Carlos Garcia Campos
Comment 7 2015-07-07 05:42:15 PDT
Committed in r186459 <http://trac.webkit.org/changeset/186459>
Note You need to log in before you can comment on or make changes to this bug.