Bug 144559 - [GTK] [Stable] DrawingBuffer.h used outside of include guard
Summary: [GTK] [Stable] DrawingBuffer.h used outside of include guard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.10
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2015-05-03 16:59 PDT by Philip Chimento
Modified: 2015-07-07 05:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch that fixes the problem (433 bytes, patch)
2015-05-03 17:01 PDT, Philip Chimento 		no flags Details | Formatted Diff | Diff
Patch that fixes the problem (1.25 KB, patch)
2015-05-07 21:58 PDT, Philip Chimento 		cgarcia: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Chimento 2015-05-03 16:59:20 PDT 
Here's a patch that fixes a header used outside of an include guard, causing the build to break if that feature wasn't enabled.
Comment 1 Philip Chimento 2015-05-03 17:01:05 PDT 
Created attachment 252293 [details]
Patch that fixes the problem
Comment 2 WebKit Commit Bot 2015-05-03 17:03:54 PDT 
Attachment 252293 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2015-05-04 08:18:34 PDT 
This file was removed from trunk - http://trac.webkit.org/changeset/181468
(Additionally the changelog is missing.)

Do you want to push this patch to a GTK release version?
Comment 4 Philip Chimento 2015-05-07 21:58:44 PDT 
Created attachment 252683 [details]
Patch that fixes the problem

Yes, this patch was for 2.8.0. If it's not valid on master anymore, then I'll propose it for inclusion in https://trac.webkit.org/wiki/WebKitGTK/2.8.x .

Here's an updated patch with changelog.
Comment 5 Philip Chimento 2015-05-10 11:45:47 PDT 
Confirmed that this patch is not needed for master.
Comment 6 Carlos Alberto Lopez Perez 2015-06-10 12:16:33 PDT 
I confirm this patch is needed for the 2.8 stable series.

Should be included in 2.8.4

Thanks
Comment 7 Carlos Garcia Campos 2015-07-07 05:42:15 PDT 
Committed in r186459 <http://trac.webkit.org/changeset/186459>