Bug 144541 – [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main loop

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

They are currently sent to the main thread run loop, because we are not setting the WorkQueue main context as the default one in the worker thread.

[Carlos Garcia Campos]

Created attachment 252263 [details]
Patch

[WebKit Commit Bot]

Attachment 252263 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Comment on attachment 252263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252263&action=review

> Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58
> +            [](GObject*, GAsyncResult*, gpointer userData) {

It's not terribly important here, but if following the usual pattern of condition usage you'd be expected to lock the context.m_lock mutex inside the lambda.

[Carlos Garcia Campos]

Committed r183800: <http://trac.webkit.org/changeset/183800>