| Summary: | display:none iframes cause repeated compositing flushing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, rniwa, sam, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2015-05-02 13:40:35 PDT
Created attachment 252244 [details]
Patch
Comment on attachment 252244 [details] Patch Attachment 252244 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6614108027748352 New failing tests: compositing/iframes/display-none-subframe.html Created attachment 252247 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 252244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252244&action=review New test is failing on Mac WebKit 1 build bot: compositing/iframes/display-none-subframe.html [ Failure ] r=me but I am worried that the test fails > Source/WebCore/page/FrameView.cpp:2599 > + FrameViewList childViews = renderedChildFrameViews(); > + for (auto& frameView : childViews) { Will work just as well without a local variable: for (auto& frameView : renderedChildFrameViews()) { > Source/WebCore/page/FrameView.cpp:4034 > + FrameViewList childViews; Might want to reserveInitialCapacity. > Source/WebCore/page/FrameView.cpp:4037 > + childViews.append(*frame->view()); If so, then could use uncheckedAppend. > Source/WebCore/page/FrameView.cpp:4064 > + FrameViewList childViews = renderedChildFrameViews(); > + for (auto& frameView : childViews) Will work just as well without a local variable: for (auto& frameView : renderedChildFrameViews()) > > Source/WebCore/page/FrameView.cpp:4034
> > + FrameViewList childViews;
>
> Might want to reserveInitialCapacity.
But it's a linear walk of child Frames to count them :(
|