Summary: | Web Inspector: NavigationSidebarPanel leaks some event listeners | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2015-05-02 09:12:10 PDT
Created attachment 252233 [details]
Patch
Comment on attachment 252233 [details]
Patch
r=me.
Looks like cq might not be able to handle this.
Comment on attachment 252233 [details] Patch Rejecting attachment 252233 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 252233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: erInterface/Views/SearchSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js Hunk #1 FAILED at 156. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6374829829652480 Comment on attachment 252233 [details] Patch https://trac.webkit.org/r184108 Landed manually. |