Bug 144523

Summary:

Web Inspector: NavigationSidebarPanel leaks some event listeners

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, commit-queue: commit-queue-

Timothy Hatcher

Reported 2015-05-02 09:12:10 PDT

Need to remove them in closed().

Attachments
Patch (5.50 KB, patch) 2015-05-02 09:12 PDT, Timothy Hatcher	joepeck: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2015-05-02 09:12:49 PDT

Created attachment 252233 [details] Patch

Joseph Pecoraro

Comment 2 2015-05-04 12:36:50 PDT

Comment on attachment 252233 [details] Patch r=me. Looks like cq might not be able to handle this.

WebKit Commit Bot

Comment 3 2015-05-04 12:38:49 PDT

Comment on attachment 252233 [details] Patch Rejecting attachment 252233 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 252233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: erInterface/Views/SearchSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js Hunk #1 FAILED at 156. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6374829829652480

Timothy Hatcher

Comment 4 2015-05-11 10:52:42 PDT

Comment on attachment 252233 [details] Patch https://trac.webkit.org/r184108

Timothy Hatcher

Comment 5 2015-05-11 12:52:01 PDT

Landed manually.

Radar WebKit Bug Importer

Comment 6 2015-05-11 12:52:29 PDT

<rdar://problem/20903134>

Note You need to log in before you can comment on or make changes to this bug.