Bug 144523 - Web Inspector: NavigationSidebarPanel leaks some event listeners
Summary: Web Inspector: NavigationSidebarPanel leaks some event listeners
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-02 09:12 PDT by Timothy Hatcher
Modified: 2015-05-11 12:52 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2015-05-02 09:12 PDT, Timothy Hatcher 		joepeck: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-05-02 09:12:10 PDT 
Need to remove them in closed().
Comment 1 Timothy Hatcher 2015-05-02 09:12:49 PDT 
Created attachment 252233 [details]
Patch
Comment 2 Joseph Pecoraro 2015-05-04 12:36:50 PDT 
Comment on attachment 252233 [details]
Patch

r=me.

Looks like cq might not be able to handle this.
Comment 3 WebKit Commit Bot 2015-05-04 12:38:49 PDT 
Comment on attachment 252233 [details]
Patch

Rejecting attachment 252233 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 252233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
erInterface/Views/SearchSidebarPanel.js
patching file Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js
Hunk #1 FAILED at 156.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6374829829652480
Comment 4 Timothy Hatcher 2015-05-11 10:52:42 PDT 
Comment on attachment 252233 [details]
Patch

https://trac.webkit.org/r184108
Comment 5 Timothy Hatcher 2015-05-11 12:52:01 PDT 
Landed manually.
Comment 6 Radar WebKit Bug Importer 2015-05-11 12:52:29 PDT 
<rdar://problem/20903134>