Bug 144519

Summary: REGRESSION: Web Inspector: Switching recordings in the Timeline navigation bar is broken
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 144520    
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2015-05-02 02:51:17 PDT
The view state is messed up when switching recordings from the navigation bar. There is an exception but there is more broken after that is fixed.
Attachments
Patch (8.17 KB, patch)
2015-05-02 03:00 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-02 02:51:37 PDT
<rdar://problem/20790228>
Timothy Hatcher
Comment 2 2015-05-02 03:00:03 PDT
Created attachment 252226 [details] Patch
Joseph Pecoraro
Comment 3 2015-05-04 11:54:41 PDT
Comment on attachment 252226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252226&action=review r=me > Source/WebInspectorUI/ChangeLog:21 > + to state restoration here. If the view existed before, use its state. If now, use the current state that Typo: "now" => "not"
WebKit Commit Bot
Comment 4 2015-05-04 12:34:58 PDT
Comment on attachment 252226 [details] Patch Clearing flags on attachment: 252226 Committed r183762: <http://trac.webkit.org/changeset/183762>
WebKit Commit Bot
Comment 5 2015-05-04 12:35:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.