| Summary: | Web Inspector: Current time marker is always at zero in Rendering Frames ruler | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 253087 [details]
[Patch] Proposed Fix
Comment on attachment 253087 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253087&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431 > if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) { Is this called when you switch from the regular timeline to the rendering frame timeline? (Will it show the right end time and current time if this wasn't the current timeline view?) (In reply to comment #3) > Comment on attachment 253087 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253087&action=review > > > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431 > > if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) { > > Is this called when you switch from the regular timeline to the rendering > frame timeline? (Will it show the right end time and current time if this > wasn't the current timeline view?) Good point, we should just check for this._renderingFrameTimeline here. Created attachment 253095 [details]
[Patch] Proposed Fix
Comment on attachment 253095 [details] [Patch] Proposed Fix Clearing flags on attachment: 253095 Committed r184336: <http://trac.webkit.org/changeset/184336> All reviewed patches have been landed. Closing bug. |
Created attachment 252224 [details] Screenshot The marker should be hidden if we don't plan to use it. Or it should be animated along the ruler as the recording happens. You can see it in the corner of the screenshot. You need to move the time selection to see it.