Bug 144518

Summary:

Web Inspector: Current time marker is always at zero in Rendering Frames ruler

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot	none
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none

Timothy Hatcher

Reported 2015-05-02 01:30:20 PDT

Created attachment 252224 [details] Screenshot The marker should be hidden if we don't plan to use it. Or it should be animated along the ruler as the recording happens. You can see it in the corner of the screenshot. You need to move the time selection to see it.

Attachments
Screenshot (20.80 KB, image/png) 2015-05-02 01:30 PDT, Timothy Hatcher	no flags	Details
[Patch] Proposed Fix (4.00 KB, patch) 2015-05-13 19:56 PDT, Matt Baker	no flags	Details Formatted Diff Diff
[Patch] Proposed Fix (4.08 KB, patch) 2015-05-13 22:11 PDT, Matt Baker	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-05-02 01:30:33 PDT

<rdar://problem/20790062>

Matt Baker

Comment 2 2015-05-13 19:56:06 PDT

Created attachment 253087 [details] [Patch] Proposed Fix

Timothy Hatcher

Comment 3 2015-05-13 20:15:20 PDT

Comment on attachment 253087 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253087&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431 > if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) { Is this called when you switch from the regular timeline to the rendering frame timeline? (Will it show the right end time and current time if this wasn't the current timeline view?)

Matt Baker

Comment 4 2015-05-13 22:08:38 PDT

(In reply to comment #3) > Comment on attachment 253087 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253087&action=review > > > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431 > > if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) { > > Is this called when you switch from the regular timeline to the rendering > frame timeline? (Will it show the right end time and current time if this > wasn't the current timeline view?) Good point, we should just check for this._renderingFrameTimeline here.

Matt Baker

Comment 5 2015-05-13 22:11:18 PDT

Created attachment 253095 [details] [Patch] Proposed Fix

WebKit Commit Bot

Comment 6 2015-05-14 08:34:40 PDT

Comment on attachment 253095 [details] [Patch] Proposed Fix Clearing flags on attachment: 253095 Committed r184336: <http://trac.webkit.org/changeset/184336>

WebKit Commit Bot

Comment 7 2015-05-14 08:34:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.