Bug 144482 – Expand test infrastructure to support scrolling tests (Part 4): Scroll Snap Support

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Brent Fulgham]

Add tests and adjustments to the scroll testing infrastructure to ensure that the scroll snap feature is fully tested.

These changes involve:
1. Make sure the WheelEventTestTrigger object is properly relayed to the scrolling thread so that scroll animations driven on the scrolling thread also block test runs.
2. Add new scroll-snap tests.

[Brent Fulgham]

Created attachment 252161 [details]
Patch

[Brent Fulgham]

Created attachment 252193 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 252193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252193&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:34
> +#include <wtf/RefPtr.h>

Not needed.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:110
>      bool m_requestedScrollPositionRepresentsProgrammaticScroll;
> +    bool m_expectsWheelEventTestTrigger;

Might as well convert these to C++11 initializersL m_expectsWheelEventTestTrigger { false };

> Source/WebCore/page/scrolling/ScrollingTree.h:105
> +    virtual void deferTestsForReason(WheelEventTestTrigger::ScrollableAreaIdentifier, WheelEventTestTrigger::DeferTestTriggerReason) { /* Do nothing */ }
> +    virtual void removeTestDeferralForReason(WheelEventTestTrigger::ScrollableAreaIdentifier, WheelEventTestTrigger::DeferTestTriggerReason) { /* Do nothing */ }

No need for "/* Do nothing */".

> Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:107
> +    bool m_expectsWheelEventTestTrigger;

m_expectsWheelEventTestTrigger { false };

[Brent Fulgham]

Comment on attachment 252193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252193&action=review

>> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:34
>> +#include <wtf/RefPtr.h>
> 
> Not needed.

I'll remove it.

>> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:110
>> +    bool m_expectsWheelEventTestTrigger;
> 
> Might as well convert these to C++11 initializersL m_expectsWheelEventTestTrigger { false };

OK.

>> Source/WebCore/page/scrolling/ScrollingTree.h:105
>> +    virtual void removeTestDeferralForReason(WheelEventTestTrigger::ScrollableAreaIdentifier, WheelEventTestTrigger::DeferTestTriggerReason) { /* Do nothing */ }
> 
> No need for "/* Do nothing */".

OK!

>> Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:107
>> +    bool m_expectsWheelEventTestTrigger;
> 
> m_expectsWheelEventTestTrigger { false };

Done.

[Brent Fulgham]

New scroll snap tests are under Bug 142358.

[Brent Fulgham]

Committed r183702: <http://trac.webkit.org/changeset/183702>