Summary: | HTMLObjectElement::data should return an absolute URL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | DOM | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | ||||||
Priority: | P3 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2007-06-28 13:45:49 PDT
patch w/ testcase coming up... Created attachment 15302 [details]
simple patch + testcase
This patch is modelled after the code for HTMLImageElement::src(). I changed the FrameLoader::completeURL call to a Document::completeURL as a minor simplification since HTMLObjectElement already has direct access to its Document.
Comment on attachment 15302 [details]
simple patch + testcase
Looks good. r=me
What about the usemap attribute?
Yes, good question. I'll investigate and file a new bug if there are similar changed needed for that. It looks like FF and IE do not return an absolute URL for the DOM useMap property; however, Opera does. This introduced two test failures: <http://build.webkit.org/results/post-commit-powerpc-mac-os-x/7125/results.html>. I will be rolling it out in a moment as we can't have regressions in the tree. Rolled out in r23913. Please be sure to run the entire layout test suite when resubmitting an updated patch. It looks like fast/loader/xmlhttprequest-bad-mimetype is still failing even after this patch was rolled back. That just leaves the two instances of object06.html (one for html and one for xhtml). It turns out that both of those tests are actually asserting the opposite of this bug report. They are testing that indeed the HTMLObjectElement's data accessor returns a relative URL instead of an absolute URL! The object06.html test seems to originate from some w3.org test suite. So, does that make this bug invalid?? Comment on attachment 15302 [details]
simple patch + testcase
Changing to r- to get this out of the commit queue.
*** This bug has been marked as a duplicate of 16799 *** |