Bug 144445

Summary: [GTK] Web Inspector: Remove some unused Images
Product: WebKit Reporter: Andres Gomez Garcia <agomez>
Component: Web InspectorAssignee: Andres Gomez Garcia <agomez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, graouts, gustavo, joepeck, jonowells, mattbaker, mrobinson, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to remove unused images in the gtk port
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Andres Gomez Garcia 2015-04-30 04:11:52 PDT 
After bug 144412 was fixed, we have some unused images in the GTK port.
Comment 1 Andres Gomez Garcia 2015-04-30 04:12:06 PDT 
Taking ...
Comment 2 Radar WebKit Bug Importer 2015-04-30 04:12:17 PDT 
<rdar://problem/20761473>
Comment 3 Andres Gomez Garcia 2015-04-30 04:17:21 PDT 
Created attachment 252050 [details]
Patch to remove unused images in the gtk port
Comment 4 Andres Gomez Garcia 2015-04-30 05:44:25 PDT 
Comment on attachment 252050 [details]
Patch to remove unused images in the gtk port

gtk build is failing :(
Comment 5 Carlos Garcia Campos 2015-04-30 05:46:59 PDT 
(In reply to comment #4)
> Comment on attachment 252050 [details]
> Patch to remove unused images in the gtk port
> 
> gtk build is failing :(

But has nothing to do with this patch, no?
Comment 6 Andres Gomez Garcia 2015-04-30 05:50:45 PDT 
Comment on attachment 252050 [details]
Patch to remove unused images in the gtk port

I, actually, don't see anything wrong with this patch ...
Comment 7 Andres Gomez Garcia 2015-04-30 06:08:00 PDT 
Created attachment 252055 [details]
Patch for landing
Comment 8 Andres Gomez Garcia 2015-04-30 06:14:40 PDT 
Created attachment 252056 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2015-04-30 06:16:27 PDT 
Comment on attachment 252056 [details]
Patch for landing

Rejecting attachment 252056 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 252056, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6716258456174592
Comment 10 Andres Gomez Garcia 2015-04-30 09:32:35 PDT 
Created attachment 252063 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2015-04-30 10:19:15 PDT 
Comment on attachment 252063 [details]
Patch for landing

Clearing flags on attachment: 252063

Committed r183627: <http://trac.webkit.org/changeset/183627>
Comment 12 WebKit Commit Bot 2015-04-30 10:19:19 PDT 
All reviewed patches have been landed.  Closing bug.