Bug 144436

Summary: Fix return code issue, check return code of safari process and dump results to log
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

dewei_zhu
Reported 2015-04-29 22:34:43 PDT
Fix return code issue, check return code of safari process and dump results to log
Attachments
Patch (5.00 KB, patch)
2015-04-29 22:41 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (5.00 KB, patch)
2015-04-29 22:48 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (4.67 KB, patch)
2015-04-29 23:18 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2015-04-29 22:41:13 PDT
Created attachment 252040 [details] Patch
Ryosuke Niwa
Comment 2 2015-04-29 22:43:11 PDT
Comment on attachment 252040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252040&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:42 > + _log.info('Safari process console output:\n\tstdout: %s\n\tstderr: %s' % self.safariProcess.communicate()) since stdout and stderr will contain multiple lines, I don't think it makes sense to indent by \t. Also, you might wanna add \n after :
dewei_zhu
Comment 3 2015-04-29 22:48:05 PDT
Created attachment 252041 [details] Patch
dewei_zhu
Comment 4 2015-04-29 23:18:11 PDT
Created attachment 252042 [details] Patch
WebKit Commit Bot
Comment 5 2015-04-30 00:09:34 PDT
Comment on attachment 252042 [details] Patch Clearing flags on attachment: 252042 Committed r183621: <http://trac.webkit.org/changeset/183621>
WebKit Commit Bot
Comment 6 2015-04-30 00:09:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.