Bug 144436 - Fix return code issue, check return code of safari process and dump results to log
Summary: Fix return code issue, check return code of safari process and dump results t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 22:34 PDT by dewei_zhu
Modified: 2015-04-30 00:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.00 KB, patch)
2015-04-29 22:41 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2015-04-29 22:48 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Patch (4.67 KB, patch)
2015-04-29 23:18 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2015-04-29 22:34:43 PDT 
Fix return code issue, check return code of safari process and dump results to log
Comment 1 dewei_zhu 2015-04-29 22:41:13 PDT 
Created attachment 252040 [details]
Patch
Comment 2 Ryosuke Niwa 2015-04-29 22:43:11 PDT 
Comment on attachment 252040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252040&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:42
> +            _log.info('Safari process console output:\n\tstdout: %s\n\tstderr: %s' % self.safariProcess.communicate())

since stdout and stderr will contain multiple lines, I don't think it makes sense to indent by \t. Also, you might wanna add \n after :
Comment 3 dewei_zhu 2015-04-29 22:48:05 PDT 
Created attachment 252041 [details]
Patch
Comment 4 dewei_zhu 2015-04-29 23:18:11 PDT 
Created attachment 252042 [details]
Patch
Comment 5 WebKit Commit Bot 2015-04-30 00:09:34 PDT 
Comment on attachment 252042 [details]
Patch

Clearing flags on attachment: 252042

Committed r183621: <http://trac.webkit.org/changeset/183621>
Comment 6 WebKit Commit Bot 2015-04-30 00:09:39 PDT 
All reviewed patches have been landed.  Closing bug.