Bug 144435

Summary: [EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_MEDIA_STREAM is ON
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2015-04-29 21:57:45 PDT
ewebkit should include openwebrtc if ENABLE_MEDIA_STREAM is ON. If not, linker will complain at the almost end of build. In order to catch it earilier, we'd better to add REQUIRED field in find_package or raise FATAL_ERROR with some message like GTK port did.
Attachments
Patch (1.90 KB, patch)
2015-04-29 22:06 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2015-04-29 23:28 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-04-29 22:06:45 PDT
Created attachment 252039 [details] Patch
Gyuyoung Kim
Comment 2 2015-04-29 22:58:16 PDT
Comment on attachment 252039 [details] Patch Oh, right. When we failed to build openwebrtc via jhbuild, it was hard to find what is problem.
Ryuan Choi
Comment 3 2015-04-29 23:28:21 PDT
Created attachment 252044 [details] Patch
Ryuan Choi
Comment 4 2015-04-29 23:38:39 PDT
Comment on attachment 252044 [details] Patch Clearing flags on attachment: 252044 Committed r183619: <http://trac.webkit.org/changeset/183619>
Ryuan Choi
Comment 5 2015-04-29 23:38:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.