Bug 144434

Summary:

Inefficient HashMap use in RTCStatsResponse.cpp

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

NEW ---

Severity:

Normal

CC:

darin, hta

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-04-29 20:41:46 PDT

* SUMMARY
Inefficient HashMap use in RTCStatsResponse.cpp.

We should never do a HashMap::find followed by a HashMap::get.

Searching JavaScriptCore & WebCore this was the only instance of that pattern!

Comment 1 Joseph Pecoraro 2015-04-29 20:43:38 PDT

Created attachment 252034 [details]
[PATCH] Proposed Fix

Comment 2 Darin Adler 2015-05-02 07:28:39 PDT

Comment on attachment 252034 [details]
[PATCH] Proposed Fix

Do you understand why the build failed on GTK and EFL?