Bug 144427

Summary:

Fix the EFL build after r183595

Product:

WebKit

Reporter:

Hunseop Jeong <hs85.jeong>

Component:

WebKit EFL

Assignee:

Hunseop Jeong <hs85.jeong>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, lucas.de.marchi, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

143684

Attachments:

Description	Flags
Patch	none
Patch	none

Description Hunseop Jeong 2015-04-29 18:59:51 PDT

../../Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:91:13: error: ‘void WebKit::updateWheelEventTestTriggersIfNeeded(uint64_t)’ defined but not used [-Werror=unused-function]
 static void updateWheelEventTestTriggersIfNeeded(uint64_t pageID)

https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21547/steps/compile-webkit/logs/stdio

Comment 1 Hunseop Jeong 2015-04-29 19:02:04 PDT

Created attachment 252022 [details]
Patch

Comment 2 Gyuyoung Kim 2015-04-29 19:27:50 PDT

Comment on attachment 252022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252022&action=review

> Source/WebKit2/ChangeLog:9
> +        (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted.

Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING).

Comment 3 Hunseop Jeong 2015-04-29 19:36:51 PDT

Created attachment 252028 [details]
Patch

Comment 4 Hunseop Jeong 2015-04-29 19:42:36 PDT

(In reply to comment #2)
> Comment on attachment 252022 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252022&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        (WebKit::updateWheelEventTestTriggersIfNeeded): Deleted.
> 
> Wrong description. updateWheelEventTestTriggersIfNeeded() is guarded by #if
> ENABLE(CSS_SCROLL_SNAP) || ENABLE(RUBBER_BANDING).

Thanks for the review. I will try to practice the writing description.

Comment 5 Gyuyoung Kim 2015-04-29 19:45:38 PDT

Comment on attachment 252028 [details]
Patch

Clearing flags on attachment: 252028

Committed r183605: <http://trac.webkit.org/changeset/183605>

Comment 6 Gyuyoung Kim 2015-04-29 19:45:44 PDT

All reviewed patches have been landed.  Closing bug.