Bug 144426

Summary:

Crash at WebCore::Document::absoluteRegionForEventTargets

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, joepeck, kangil.han, simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

144432

Bug Blocks:

Attachments:

Description	Flags
Patch	thorton: review+

Simon Fraser (smfr)

Reported 2015-04-29 18:29:26 PDT

Crash at WebCore::Document::absoluteRegionForEventTargets

Attachments
Patch (9.82 KB, patch) 2015-04-29 18:32 PDT, Simon Fraser (smfr)	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2015-04-29 18:32:23 PDT

Created attachment 252020 [details] Patch

Simon Fraser (smfr)

Comment 2 2015-04-29 18:33:05 PDT

rdar://problem/20502166

Tim Horton

Comment 3 2015-04-29 18:35:27 PDT

Comment on attachment 252020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252020&action=review > LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6 > +PASS internals.wheelEventHandlerCount() is 0 Are there tests that test that this works at all?

Simon Fraser (smfr)

Comment 4 2015-04-29 18:36:07 PDT

(In reply to comment #3) > Comment on attachment 252020 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252020&action=review > > > LayoutTests/fast/events/wheelevent-in-reattached-frame-expected.txt:6 > > +PASS internals.wheelEventHandlerCount() is 0 Yes! > Are there tests that test that this works at all?

Simon Fraser (smfr)

Comment 5 2015-04-29 18:40:06 PDT

https://trac.webkit.org/r183600

Alexey Proskuryakov

Comment 6 2015-04-29 19:15:54 PDT

This broke a bunch of tests: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r183600%20(13679)/results.html Simon, are you available to fix now?

Alexey Proskuryakov

Comment 7 2015-04-29 19:58:35 PDT

And by "a bunch", I mean the two new tests: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fwheelevent-in-frame.html https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fevents%2Fwheelevent-in-reattached-frame.html Rolling out.

WebKit Commit Bot

Comment 8 2015-04-29 19:58:47 PDT

Re-opened since this is blocked by bug 144432