Bug 144419

Summary:

Run javascriptcore tests on Windows without cygwin

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

Tools / Tests

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Alex Christensen 2015-04-29 16:23:35 PDT

/usr/bin/env doesn't work well without cygwin.  It probably isn't necessary, anyways.

Comment 1 Alex Christensen 2015-04-29 16:24:13 PDT

Created attachment 252003 [details]
Patch

Comment 2 Brent Fulgham 2015-04-29 16:26:19 PDT

Comment on attachment 252003 [details]
Patch

Will this break things for UNIX users? I think "/usr/bin/env" is the canonical way to get the path to an executable (which might be /usr/bin/ruby, /usr/local/bin/ruby, /opt/local/bin/ruby, etc.)

Comment 3 Alex Christensen 2015-04-29 16:33:17 PDT

Created attachment 252005 [details]
Patch

Comment 4 Brent Fulgham 2015-04-29 16:34:12 PDT

Comment on attachment 252005 [details]
Patch

r=me.

Comment 5 Alex Christensen 2015-04-29 16:35:15 PDT

Created attachment 252006 [details]
Patch

Comment 6 WebKit Commit Bot 2015-04-29 17:25:10 PDT

Comment on attachment 252006 [details]
Patch

Clearing flags on attachment: 252006

Committed r183593: <http://trac.webkit.org/changeset/183593>

Comment 7 WebKit Commit Bot 2015-04-29 17:25:12 PDT

All reviewed patches have been landed.  Closing bug.