Bug 144415

Summary: Web Inspector: Remove FrameContentView.js
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2015-04-29 15:40:49 PDT
We don't use FrameContentView.js anymore.
Attachments
Patch (15.51 KB, patch)
2015-04-29 15:42 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2015-04-29 15:42:32 PDT
Created attachment 251996 [details] Patch
Andres Gomez Garcia
Comment 2 2015-04-30 04:27:06 PDT
Comment on attachment 251996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251996&action=review > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Images/SourceCode.svg: Removed. Could you also remove these SVG images in the gtk subdir?
Joseph Pecoraro
Comment 3 2015-04-30 12:09:50 PDT
Comment on attachment 251996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251996&action=review r=me, Might still be able to remove the GTK images. > Source/WebInspectorUI/ChangeLog:19 > + * UserInterface/Views/ResourceSidebarPanel.js: > + (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork): > + (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange): > + Simplify the code here. We don't need these checks now with tabs and the Storage tab. Could be its own change.
Timothy Hatcher
Comment 4 2015-05-01 07:25:47 PDT
Comment on attachment 251996 [details] Patch https://trac.webkit.org/r183671
Note You need to log in before you can comment on or make changes to this bug.