Bug 144395

Summary:

check-webkit-style: Don't complain about returning value from Objective-C method call in header

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, bfulgham, commit-queue, ddkilzer, dino, fpizlo, glenn, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2015-04-29 10:07:27 PDT

In Bug 144362, an inline method was added to SoftLinking.h that returned the value from an Objective-C method call:

+    inline className *alloc##className##Instance() \
+    { \
+        return [get_##framework##_##className##Class() alloc]; \
+    } \

However, check-webkit-style incorrectly flagged this as a style issue (see Bug 144362, Comment #24):

ERROR: Source/WebCore/platform/mac/SoftLinking.h:327:  Extra space before [  [whitespace/braces] [5]

Additional issues noted while investigating this:
- The category should be "whitespace/brackets", not "whitespace/braces".
- There is no test coverage for the code that checks for "whitespace/brackets".

Comment 1 David Kilzer (:ddkilzer) 2015-04-29 10:19:15 PDT

Created attachment 251962 [details]
Patch v1

Comment 2 WebKit Commit Bot 2015-04-29 12:34:10 PDT

Comment on attachment 251962 [details]
Patch v1

Clearing flags on attachment: 251962

Committed r183567: <http://trac.webkit.org/changeset/183567>

Comment 3 WebKit Commit Bot 2015-04-29 12:34:16 PDT

All reviewed patches have been landed.  Closing bug.