Bug 144390

Summary:

Web Inspector: Remove Legacy images and styles

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-

Description Timothy Hatcher 2015-04-29 08:48:44 PDT

The Legacy path is poor shape and hard to maintain and test.

Comment 1 Timothy Hatcher 2015-04-29 08:53:58 PDT

Created attachment 251954 [details]
Patch

Comment 2 Joseph Pecoraro 2015-04-29 11:59:10 PDT

Comment on attachment 251954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251954&action=review

Awesome! r=me, with 1 nit

> Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js:531
> +        generateModernImage();

The contents of this function are now just function foo() {}; foo();. You can drop the "inner function" and just inline it.

Comment 3 Timothy Hatcher 2015-04-29 15:02:48 PDT

Comment on attachment 251954 [details]
Patch

https://trac.webkit.org/r183579