Bug 144390

Summary: Web Inspector: Remove Legacy images and styles
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2015-04-29 08:48:44 PDT
The Legacy path is poor shape and hard to maintain and test.
Attachments
Patch (204.97 KB, patch)
2015-04-29 08:53 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2015-04-29 08:53:58 PDT
Created attachment 251954 [details] Patch
Joseph Pecoraro
Comment 2 2015-04-29 11:59:10 PDT
Comment on attachment 251954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251954&action=review Awesome! r=me, with 1 nit > Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js:531 > + generateModernImage(); The contents of this function are now just function foo() {}; foo();. You can drop the "inner function" and just inline it.
Timothy Hatcher
Comment 3 2015-04-29 15:02:48 PDT
Comment on attachment 251954 [details] Patch https://trac.webkit.org/r183579
Note You need to log in before you can comment on or make changes to this bug.