Bug 144384

Summary: [CSS Box Alignment] Unifying alignment data in a single class
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, darin, hyatt, jfernandez, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Javier Fernandez
Reported 2015-04-29 04:37:44 PDT
The new CSS Box Alignment specification introduces more complex values and syntax for defining alignment properties. Most of the alignment values were just keyword identifiers, but the new syntax allows different combinations of identifiers to determine the alignment behavior (eg. overflow-alignment keyword). This bug describes the need of a refactoring of current alignment logic to define one or more classes to store all the alignment fields. This class will replace the unsigned fields in the StyleRareNonInherited class, hence it will increase it sized considerably. We should take that into account when submitting and reviewing patches.
Attachments
Patch (46.28 KB, patch)
2015-04-29 04:56 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (50.05 KB, patch)
2015-04-29 13:40 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-04-29 04:56:00 PDT
Created attachment 251946 [details] Patch
Darin Adler
Comment 2 2015-04-29 08:41:23 PDT
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/StyleRareNonInheritedData.h:37:10: fatal error: 'StyleSelfAlignmentData.h' file not found I suspect this is adding a new header file to the Xcode project but not marking it “Private”, which is needed if it’s used outside WebCore.
Javier Fernandez
Comment 3 2015-04-29 13:40:09 PDT
Created attachment 251982 [details] Patch
Dave Hyatt
Comment 4 2015-04-29 16:24:33 PDT
Comment on attachment 251982 [details] Patch r=me
WebKit Commit Bot
Comment 5 2015-04-29 17:15:00 PDT
Comment on attachment 251982 [details] Patch Clearing flags on attachment: 251982 Committed r183591: <http://trac.webkit.org/changeset/183591>
WebKit Commit Bot
Comment 6 2015-04-29 17:15:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.