Bug 144382

Summary: [cmake] Disable GNU Gold linker on Cortex A53
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: akiss, berto, cgarcia, mcatanzaro, mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-04-29 03:06:17 PDT
https://bugs.webkit.org/show_bug.cgi?id=138840#c5 The problem is that -mfix-cortex-a53-835769 errata detection is placed before the gold linker detection. It tries to detect if the default system linker supports it and later uses gold linker for the real build. I can't found any commit in trunk gold linker, so the easiest fix is to disable gold linker on Cortex A53 to be able to use the necessary workaround.
Attachments
Patch (1.73 KB, patch)
2015-04-29 03:17 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2015-04-29 09:55 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2015-04-29 03:11:56 PDT
Yeah, that looks like the best solution to me as well.
Csaba Osztrogonác
Comment 2 2015-04-29 03:17:13 PDT
Created attachment 251941 [details] Patch WIP patch, I'm going to check it on real hardware.
Michael Catanzaro
Comment 3 2015-04-29 08:02:31 PDT
OK... so CMAKE_DEPENDENT_OPTION is a thing.... There's a typo in the patch: workaroung -> workaround.
Csaba Osztrogonác
Comment 4 2015-04-29 09:55:59 PDT
Created attachment 251961 [details] Patch I fixed the mentioned typo, added the necessary include and negated CXX_ACCEPTS_MFIX_CORTEX_A53_835769 in CMAKE_DEPENDENT_OPTION which was wrong in my previous patch. (tested on real hw)
Alberto Garcia
Comment 5 2015-04-29 14:10:13 PDT
(In reply to comment #4) > Created attachment 251961 [details] > Patch > > I fixed the mentioned typo, added the necessary include and negated > CXX_ACCEPTS_MFIX_CORTEX_A53_835769 in CMAKE_DEPENDENT_OPTION which was wrong > in my previous patch. (tested on real hw) Looks good to me, thanks for testing it!
Csaba Osztrogonác
Comment 6 2015-05-04 01:50:46 PDT
I asked the authors of the errata fix in BFD linker and they said that only the BFD linker is supported and they aren't planning to add this fix to the gold linker. So this change is really the correct fix.
Csaba Osztrogonác
Comment 7 2015-05-04 01:52:46 PDT
Comment on attachment 251961 [details] Patch Clearing flags on attachment: 251961 Committed r183741: <http://trac.webkit.org/changeset/183741>
Csaba Osztrogonác
Comment 8 2015-05-04 01:52:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.