Bug 144379

Summary: [GTK] Add libnotify in gtk install-dependencies
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: WebKitGTKAssignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, mcatanzaro, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Joonghun Park
Reported 2015-04-29 00:28:22 PDT
Add libnotify-dev in install-dependencies of Gtk port. Without this dependency package, Gtk port build is impossible currently.
Attachments
Patch (1.07 KB, patch)
2015-04-29 00:34 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2015-04-29 01:36 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2015-04-29 01:49 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2015-04-29 01:53 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2015-04-29 02:06 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2015-05-01 02:00 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2015-04-29 00:34:37 PDT
Created attachment 251929 [details] Patch
Zan Dobersek
Comment 2 2015-04-29 01:13:30 PDT
Comment on attachment 251929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251929&action=review > Tools/gtk/install-dependencies:81 > + libnotify-dev \ This should use spaces instead of tabs. Please fix before committing.
Joonghun Park
Comment 3 2015-04-29 01:30:53 PDT
(In reply to comment #2) > Comment on attachment 251929 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251929&action=review > > > Tools/gtk/install-dependencies:81 > > + libnotify-dev \ > > This should use spaces instead of tabs. Please fix before committing. Ok, I will revise it :)
Joonghun Park
Comment 4 2015-04-29 01:36:30 PDT
Created attachment 251933 [details] Patch
Gyuyoung Kim
Comment 5 2015-04-29 01:39:09 PDT
Comment on attachment 251933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251933&action=review > Tools/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Missing reviewer name here, because Zan set r+ed.
Joonghun Park
Comment 6 2015-04-29 01:43:25 PDT
(In reply to comment #5) > Comment on attachment 251933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=251933&action=review > > > Tools/ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > Missing reviewer name here, because Zan set r+ed. Ah, I had to write it into ChangeLog, but I missed it. Thank you, I will re-upload this one.
Joonghun Park
Comment 7 2015-04-29 01:49:14 PDT
Created attachment 251934 [details] Patch
Joonghun Park
Comment 8 2015-04-29 01:53:51 PDT
Created attachment 251935 [details] Patch
Joonghun Park
Comment 9 2015-04-29 02:06:24 PDT
Created attachment 251936 [details] Patch
WebKit Commit Bot
Comment 10 2015-04-29 02:59:57 PDT
Comment on attachment 251936 [details] Patch Clearing flags on attachment: 251936 Committed r183539: <http://trac.webkit.org/changeset/183539>
WebKit Commit Bot
Comment 11 2015-04-29 03:00:02 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 12 2015-04-29 11:04:12 PDT
Reopening: please make sure to fix all three supported distros (Arch, Debian, Fedora) when modifying this file. The Arch package is simply libnotify and the Fedora package is libnotify-devel.
Gyuyoung Kim
Comment 13 2015-04-29 17:48:27 PDT
(In reply to comment #12) > Reopening: please make sure to fix all three supported distros (Arch, > Debian, Fedora) when modifying this file. The Arch package is simply > libnotify and the Fedora package is libnotify-devel. Has GTK port's install-dependency script supported Fedora, Arch as well ?
Michael Catanzaro
Comment 14 2015-04-29 19:25:02 PDT
(In reply to comment #13) > Has GTK port's install-dependency script supported Fedora, Arch as well ? Yup. (More distros welcome.)
Joonghun Park
Comment 15 2015-05-01 01:48:39 PDT
(In reply to comment #12) > Reopening: please make sure to fix all three supported distros (Arch, > Debian, Fedora) when modifying this file. The Arch package is simply > libnotify and the Fedora package is libnotify-devel. I didn't know which distros GTK port supports currently. Thank you for your teaching :) For now, I will add what you commented here for Fedora and Arch.
Joonghun Park
Comment 16 2015-05-01 02:00:11 PDT
Created attachment 252143 [details] Patch
Csaba Osztrogonác
Comment 17 2015-05-04 03:33:24 PDT
Comment on attachment 252143 [details] Patch LGTM
WebKit Commit Bot
Comment 18 2015-05-04 04:21:31 PDT
Comment on attachment 252143 [details] Patch Clearing flags on attachment: 252143 Committed r183743: <http://trac.webkit.org/changeset/183743>
WebKit Commit Bot
Comment 19 2015-05-04 04:21:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.