Summary: | REGRESSION(181868): Windows Live SkyDrive cannot open an excel file | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren, joepeck | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-04-28 20:27:07 PDT
Hmm, it seems Web IDL prefers that interface attributes be configurable by default: http://www.w3.org/TR/WebIDL/#es-attributes > The property has attributes > { [[Get]]: G, [[Set]]: S, [[Enumerable]]: true, [[Configurable]]: configurable }, > where: configurable is false if the attribute was declared with the > [Unforgeable] extended attribute and true otherwise; Seems like the ultimate best path forward would be to: (1) Make IDL attributes configurable (2) Keep this exception when trying to reconfigure a non-configurable property. But for now, lets just go back to failing silently. Created attachment 251920 [details]
[PATCH] Proposed Fix
=(. This will Reopen 142934 and in there I have a plan for hopefully re-enabling this warning.
Comment on attachment 251920 [details] [PATCH] Proposed Fix Clearing flags on attachment: 251920 Committed r183535: <http://trac.webkit.org/changeset/183535> All reviewed patches have been landed. Closing bug. > • Firefox: the properties don’t exist on HTMLElement.prototype, so they are
> created
O'rly? Most DOM properties in Firefox are getters and setters in the prototype chain. Out of curiosity, where *does* Firefox define innerText?
(In reply to comment #6) > > • Firefox: the properties don’t exist on HTMLElement.prototype, so they are > > created > > O'rly? Most DOM properties in Firefox are getters and setters in the > prototype chain. Out of curiosity, where *does* Firefox define innerText? Firefox doesn't appear to support "innerText" at all. |