Bug 144364

Summary: [CMake] [GTK] Organize and clean up unused CMake variables
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, ossy, pnormand, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2015-04-28 16:45:14 PDT
We can lighten up OptionsGTK.cmake a bit by removing unused variables and moving some to more appropriate locations.
Attachments
Patch (8.58 KB, patch)
2015-04-28 16:49 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2015-04-28 16:49:21 PDT
Created attachment 251897 [details] Patch
Michael Catanzaro
Comment 2 2015-04-28 17:32:54 PDT
Looks good to me.
Gyuyoung Kim
Comment 3 2015-04-28 18:01:15 PDT
Comment on attachment 251897 [details] Patch Looks fine.
Martin Robinson
Comment 4 2015-04-29 09:21:47 PDT
Comment on attachment 251897 [details] Patch Clearing flags on attachment: 251897 Committed r183550: <http://trac.webkit.org/changeset/183550>
Martin Robinson
Comment 5 2015-04-29 09:21:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.