Bug 144361

Summary: Increase stablility of run-benchmark script
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dewei_zhu, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

dewei_zhu
Reported 2015-04-28 16:30:04 PDT
Increase stablility of run-benchmark script
Attachments
Patch (21.98 KB, patch)
2015-04-28 16:39 PDT, dewei_zhu
no flags
dewei_zhu
Comment 1 2015-04-28 16:39:41 PDT
WebKit Commit Bot
Comment 2 2015-04-28 16:42:11 PDT
Attachment 251895 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:83: [SimpleHTTPServerDriver.killServer] Instance of 'Popen' has no 'terminate' member [pylint/E1101] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2015-04-28 16:53:09 PDT
Comment on attachment 251895 [details] Patch Rejecting attachment 251895 [details] from commit-queue. dewei_zhu@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 4 2015-04-28 17:52:50 PDT
Comment on attachment 251895 [details] Patch Clearing flags on attachment: 251895 Committed r183520: <http://trac.webkit.org/changeset/183520>
WebKit Commit Bot
Comment 5 2015-04-28 17:52:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.