Bug 144356

Summary: Failure when building WebKit for appletvsimulator
Product: WebKit Reporter: Jake Nielsen <jacob_nielsen>
Component: New BugsAssignee: Jake Nielsen <jake.nielsen.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, jake.nielsen.webkit, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jake Nielsen
Reported 2015-04-28 14:09:17 PDT
See rdar://problem/20641901 for details
Attachments
Patch (2.81 KB, patch)
2015-04-28 14:18 PDT, Jake Nielsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jake Nielsen
Comment 1 2015-04-28 14:18:09 PDT
Created attachment 251886 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-29 15:42:35 PDT
Comment on attachment 251886 [details] Patch Clearing flags on attachment: 251886 Committed r183583: <http://trac.webkit.org/changeset/183583>
WebKit Commit Bot
Comment 3 2015-04-29 15:42:40 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 4 2015-04-29 17:42:36 PDT
Comment on attachment 251886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review > Tools/WebKitTestRunner/Makefile:11 > -ifneq (,$(findstring iphone,$(SDKROOT))) > +ifeq (,$(findstring macosx,$(SDKROOT))) > ifeq (,$(findstring clean,$(MAKECMDGOALS))) > OTHER_OPTIONS += -target WebKitTestRunnerApp > endif This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs.
Joseph Pecoraro
Comment 5 2015-04-29 17:43:18 PDT
Comment on attachment 251886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review >> Tools/WebKitTestRunner/Makefile:11 >> endif > > This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs. To test, on a Mac: shell> cd Tools/WebKitTestRunner; make => errors building WebKitTestRunnerApp
Joseph Pecoraro
Comment 6 2015-04-29 17:48:42 PDT
Ahh, interesting. This tends to be the case when SDKROOT is not set. shell> make SDKROOT=macosx release => all is fine shell> make release => failures trying to build WebKitTestRunnerApp We probably should treat an empty SDKROOT as macosx.
Jake Nielsen
Comment 7 2015-04-29 17:50:12 PDT
:(
Note You need to log in before you can comment on or make changes to this bug.