| Summary: | Failure when building WebKit for appletvsimulator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jake Nielsen <jacob_nielsen> | ||||
| Component: | New Bugs | Assignee: | Jake Nielsen <jake.nielsen.webkit> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dbates, ddkilzer, jake.nielsen.webkit, joepeck | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Jake Nielsen
2015-04-28 14:09:17 PDT
Created attachment 251886 [details]
Patch
Comment on attachment 251886 [details] Patch Clearing flags on attachment: 251886 Committed r183583: <http://trac.webkit.org/changeset/183583> All reviewed patches have been landed. Closing bug. Comment on attachment 251886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review > Tools/WebKitTestRunner/Makefile:11 > -ifneq (,$(findstring iphone,$(SDKROOT))) > +ifeq (,$(findstring macosx,$(SDKROOT))) > ifeq (,$(findstring clean,$(MAKECMDGOALS))) > OTHER_OPTIONS += -target WebKitTestRunnerApp > endif This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs. Comment on attachment 251886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251886&action=review >> Tools/WebKitTestRunner/Makefile:11 >> endif > > This seems to cause "WebKitTestRunnerApp" to sometimes build on Mac, which causes failures, since the target won't build with macosx SDKs. To test, on a Mac: shell> cd Tools/WebKitTestRunner; make => errors building WebKitTestRunnerApp Ahh, interesting. This tends to be the case when SDKROOT is not set.
shell> make SDKROOT=macosx release
=> all is fine
shell> make release
=> failures trying to build WebKitTestRunnerApp
We probably should treat an empty SDKROOT as macosx.
:( |