Bug 144308

Summary:

Disable App Nap in WebKitTestRunner UI process

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, barraclough, cdumez, dbates, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=108400
https://bugs.webkit.org/show_bug.cgi?id=144155

Attachments:

Description	Flags
proposed patch	dbates: review+, dbates: commit-queue-

Description Alexey Proskuryakov 2015-04-27 19:46:18 PDT

DumpRenderTree disables App Nap since bug 108400, and I just made WebKit2 secondary processes not app nap in bug 144155. But WebKitTestRunner itself can still be suppressed, as far as I can tell.

Comment 1 Alexey Proskuryakov 2015-04-27 19:52:03 PDT

Created attachment 251808 [details]
proposed patch

This changes process role from TASK_BACKGROUND_APPLICATION to TASK_UNSPECIFIED. I don't know all the ramifications, but at least the patch is not a no-op, and it makes WKTR more like DRT.

Comment 2 Daniel Bates 2015-04-28 09:15:51 PDT

Comment on attachment 251808 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251808&action=review

This looks sane to me.

> Tools/WebKitTestRunner/mac/main.mm:45
> +    static id assertion = [[[NSProcessInfo processInfo] beginActivityWithOptions:options reason:@"DumpRenderTree should not be subject to process suppression"] retain];

DumpRenderTree => WebKitTestRunner

Comment 3 Alexey Proskuryakov 2015-04-28 10:46:25 PDT

Committed r183488.