Bug 144299

Summary: PDF action menu fixes
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: PDFAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 144307    
Attachments:
Description Flags
Patch thorton: review+

Description Brent Fulgham 2015-04-27 17:52:58 PDT 
After playing with the recent PDF updates, we noticed two problems:

1. The TextIdentifier (yellow highlights) shown when displaying a definition for a word were slightly offset.
2. Zooming out the PDF so that multiple pages were shown in the same WebView caused improper display of the dictionary overlay.
Comment 1 Brent Fulgham 2015-04-27 17:53:38 PDT 
<rdar://problem/20702215>
Comment 2 Brent Fulgham 2015-04-27 17:58:47 PDT 
Created attachment 251799 [details]
Patch
Comment 3 Tim Horton 2015-04-27 18:26:57 PDT 
Comment on attachment 251799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251799&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:625
> +    // Based on TextIndicator implementation:
> +    CGFloat verticalMargin = 2.5;
> +    CGFloat horizontalMargin = 0.5;

We should (separately) figure out a way to make this not be copied into clients who aren't TextIndicator
Comment 4 Brent Fulgham 2015-04-27 19:44:50 PDT 
Committed r183447: <http://trac.webkit.org/changeset/183447>