Bug 144271

Summary:

WirelessTargetPicker should not be visible unless a file is playable

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	jer.noble: review+
Patch for landing.	none

Description Eric Carlson 2015-04-27 11:18:05 PDT

Don't show the picker button until we know a file can be played.

Comment 1 Eric Carlson 2015-04-27 11:23:06 PDT

<rdar://problem/20712003>

Comment 2 Eric Carlson 2015-04-27 11:24:59 PDT

Created attachment 251761 [details]
Proposed patch.

Comment 3 Jer Noble 2015-04-27 11:29:59 PDT

Comment on attachment 251761 [details]
Proposed patch.

Nit: it'd be nice if we could pull out the logic in updateStatusDisplay() into something like "isPlayable()", but this is fine as-is.

Comment 4 Eric Carlson 2015-04-27 12:39:57 PDT

Created attachment 251770 [details]
Patch for landing.

Comment 5 WebKit Commit Bot 2015-04-27 13:34:29 PDT

Comment on attachment 251770 [details]
Patch for landing.

Clearing flags on attachment: 251770

Committed r183417: <http://trac.webkit.org/changeset/183417>