Bug 144268

Summary: LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2015-04-27 10:53:25 PDT
The call to loadVariable(.) both for 32bit and 64bit seems unnecessary. It grabs a value that is immediately overwritten by a call to getGlobalVar(). It should be safe to just delete these calls.
Attachments
patch (1.91 KB, patch)
2015-06-15 18:35 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2015-06-15 18:35:31 PDT
Created attachment 254916 [details] patch Let's see what EWS thinks. Running tests locally, too.
WebKit Commit Bot
Comment 2 2015-06-16 11:35:04 PDT
Comment on attachment 254916 [details] patch Clearing flags on attachment: 254916 Committed r185596: <http://trac.webkit.org/changeset/185596>
WebKit Commit Bot
Comment 3 2015-06-16 11:35:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.