Bug 144268

Summary:

LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2015-04-27 10:53:25 PDT

The call to loadVariable(.) both for 32bit and 64bit seems unnecessary. 
It grabs a value that is immediately overwritten by a call to getGlobalVar(). 
It should be safe to just delete these calls.

Comment 1 Saam Barati 2015-06-15 18:35:31 PDT

Created attachment 254916 [details]
patch

Let's see what EWS thinks.
Running tests locally, too.

Comment 2 WebKit Commit Bot 2015-06-16 11:35:04 PDT

Comment on attachment 254916 [details]
patch

Clearing flags on attachment: 254916

Committed r185596: <http://trac.webkit.org/changeset/185596>

Comment 3 WebKit Commit Bot 2015-06-16 11:35:07 PDT

All reviewed patches have been landed.  Closing bug.