Bug 144243

Summary:

Getter or setter method named "prototype" or "constructor" should throw SyntaxError

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

JavaScriptCore

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, darin, fpizlo, ggaren, mark.lam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

140491

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2015-04-26 17:47:34 PDT

We shouldn't allow getter or setter (either instance and static) method of name "prototype" or "constructor".

Comment 1 Ryosuke Niwa 2015-04-26 18:27:33 PDT

Created attachment 251716 [details]
Fixes the bug

Comment 2 Ryosuke Niwa 2015-04-26 20:32:12 PDT

Comment on attachment 251716 [details]
Fixes the bug

Thanks for the review!

Comment 3 WebKit Commit Bot 2015-04-26 21:19:31 PDT

Comment on attachment 251716 [details]
Fixes the bug

Clearing flags on attachment: 251716

Committed r183382: <http://trac.webkit.org/changeset/183382>

Comment 4 WebKit Commit Bot 2015-04-26 21:19:39 PDT

All reviewed patches have been landed.  Closing bug.