Bug 144239

Summary: Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2015-04-26 16:24:39 PDT
Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad is most cases, but if the select tab supports the same represented object, it can end up showing the content view in the wrong tab.
Attachments
Patch (7.40 KB, patch)
2015-04-26 16:26 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2015-04-26 16:26:23 PDT
Created attachment 251712 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-26 18:25:49 PDT
Comment on attachment 251712 [details] Patch Clearing flags on attachment: 251712 Committed r183375: <http://trac.webkit.org/changeset/183375>
WebKit Commit Bot
Comment 3 2015-04-26 18:25:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.