Bug 144239

Summary:

Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2015-04-26 16:24:39 PDT

Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad is most cases, but if the select tab supports the same represented object, it can end up showing the content view in the wrong tab.

Comment 1 Timothy Hatcher 2015-04-26 16:26:23 PDT

Created attachment 251712 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-26 18:25:49 PDT

Comment on attachment 251712 [details]
Patch

Clearing flags on attachment: 251712

Committed r183375: <http://trac.webkit.org/changeset/183375>

Comment 3 WebKit Commit Bot 2015-04-26 18:25:53 PDT

All reviewed patches have been landed.  Closing bug.