Bug 144237

Summary:

REGRESSION (r174283): disabled default buttons use impossible-to-read white text on Mac

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Forms

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, mitz

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Darin Adler 2015-04-26 15:47:38 PDT

REGRESSION (r174283): disabled default buttons use impossible-to-read white text on Mac

Comment 1 Darin Adler 2015-04-26 15:50:57 PDT

Created attachment 251711 [details]
Patch

Comment 2 Darin Adler 2015-04-26 15:51:32 PDT

<rdar://problem/19523555>

Comment 3 Simon Fraser (smfr) 2015-04-26 18:05:10 PDT

Comment on attachment 251711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251711&action=review

> Source/WebCore/rendering/RenderTheme.cpp:180
> +        // Special style that tells enabled default in active windows to use the ActiveButtonText color.

enabled default *button*?

Comment 4 mitz 2015-04-26 18:06:27 PDT

Comment on attachment 251711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251711&action=review

> Source/WebCore/rendering/RenderTheme.cpp:180
> +        // Special style that tells enabled default in active windows to use the ActiveButtonText color.

Missing word before “in”.

Comment 5 Darin Adler 2015-04-26 19:05:22 PDT

Committed r183378: <http://trac.webkit.org/changeset/183378>