Bug 144219

Summary:

[WK2] API::URL creation functions should return Ref<>

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	darin: review+

Description Zan Dobersek 2015-04-26 06:37:27 PDT

API::URL creation functions should return Ref<>

Comment 1 Zan Dobersek 2015-04-26 06:38:37 PDT

Created attachment 251683 [details]
Patch

Comment 2 WebKit Commit Bot 2015-04-26 06:39:45 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Zan Dobersek 2015-04-26 07:02:59 PDT

Created attachment 251690 [details]
Patch

Comment 4 Darin Adler 2015-04-26 11:58:26 PDT

Comment on attachment 251690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251690&action=review

> Source/WebKit2/Shared/API/c/WKSharedAPICast.h:177
>          return 0;

nullptr

Comment 5 Zan Dobersek 2015-04-27 13:10:55 PDT

Committed r183410: <http://trac.webkit.org/changeset/183410>