Bug 144219

Summary: [WK2] API::URL creation functions should return Ref<>
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Zan Dobersek
Reported 2015-04-26 06:37:27 PDT
API::URL creation functions should return Ref<>
Attachments
Patch (6.84 KB, patch)
2015-04-26 06:38 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.85 KB, patch)
2015-04-26 07:02 PDT, Zan Dobersek 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-04-26 06:38:37 PDT
Created attachment 251683 [details] Patch
WebKit Commit Bot
Comment 2 2015-04-26 06:39:45 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2015-04-26 07:02:59 PDT
Created attachment 251690 [details] Patch
Darin Adler
Comment 4 2015-04-26 11:58:26 PDT
Comment on attachment 251690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251690&action=review > Source/WebKit2/Shared/API/c/WKSharedAPICast.h:177 > return 0; nullptr
Zan Dobersek
Comment 5 2015-04-27 13:10:55 PDT
Committed r183410: <http://trac.webkit.org/changeset/183410>
Note You need to log in before you can comment on or make changes to this bug.