| Summary: | Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Timothy Hatcher
2015-04-25 15:45:24 PDT
Created attachment 251649 [details]
Patch
Created attachment 251650 [details]
Screenshot
(In reply to comment #2) > Created attachment 251650 [details] > Screenshot I wonder if the Search placeholder should somehow be centered. That is the case on my Yosemite Mail.app's search field. Potential for a future polish patch. Comment on attachment 251649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251649&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SearchBar.js:28 > + constructor(identifier, placeholder, delegate, supressIncremental) Typo: "supress" => "suppress" > Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:45 > + this._inputElement.setAttribute("placeholder", WebInspector.UIString("Search Resource Content")); I think this can just be a property and not a "setAttribute". Probably the others as well, but I'm not as certain for those. |