Bug 144197

Summary: Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+, timothy: commit-queue-
Screenshot none

Timothy Hatcher
Reported 2015-04-25 15:45:24 PDT
Search results should be their own tab.
Attachments
Patch (67.71 KB, patch)
2015-04-25 15:46 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Screenshot (705.69 KB, image/png)
2015-04-25 15:48 PDT, Timothy Hatcher 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2015-04-25 15:46:29 PDT
Created attachment 251649 [details] Patch
Timothy Hatcher
Comment 2 2015-04-25 15:48:06 PDT
Created attachment 251650 [details] Screenshot
Joseph Pecoraro
Comment 3 2015-04-25 17:36:36 PDT
(In reply to comment #2) > Created attachment 251650 [details] > Screenshot I wonder if the Search placeholder should somehow be centered. That is the case on my Yosemite Mail.app's search field. Potential for a future polish patch.
Joseph Pecoraro
Comment 4 2015-04-25 17:44:00 PDT
Comment on attachment 251649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251649&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SearchBar.js:28 > + constructor(identifier, placeholder, delegate, supressIncremental) Typo: "supress" => "suppress" > Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:45 > + this._inputElement.setAttribute("placeholder", WebInspector.UIString("Search Resource Content")); I think this can just be a property and not a "setAttribute". Probably the others as well, but I'm not as certain for those.
Timothy Hatcher
Comment 5 2015-04-25 18:36:03 PDT
r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342
Note You need to log in before you can comment on or make changes to this bug.