Bug 144180

Summary:

Implement parsing support for font-synthesis CSS property

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Myles C. Maxfield 2015-04-24 19:14:58 PDT

Implement parsing support for font-synthesis CSS property

Comment 1 Myles C. Maxfield 2015-04-24 19:16:12 PDT

Created attachment 251603 [details]
Patch

Comment 2 Myles C. Maxfield 2015-04-24 19:16:37 PDT

<rdar://problem/20692791>

Comment 3 Myles C. Maxfield 2015-04-24 19:18:02 PDT

Comment on attachment 251603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251603&action=review

> LayoutTests/fast/css3-text/font-synthesis-parse.html:93
> +    stylesheet.insertRule("#p { font-synthesis: weight style }", 0);

Add a test for duplicate valid values

Comment 4 Tim Horton 2015-04-24 19:27:51 PDT

Comment on attachment 251603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251603&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=144180

please put the radar here

> Source/WebCore/ChangeLog:15
> +        * css/CSSComputedStyleDeclaration.cpp:

more comments!

> Source/WebCore/css/StyleBuilderCustom.h:1386
> +    bool encounteredStyle = false;

Flags would make this look less silly too

> Source/WebCore/rendering/style/RenderStyleConstants.h:423
> +    FontSynthesisWeight = 0x1,
> +    FontSynthesisStyle = 0x2,
> +    FontSynthesisWeightAndStyle = 0x3

This looks ripe for bitflagging, no? Like TextDecoration, below.

Comment 5 Myles C. Maxfield 2015-04-24 20:30:33 PDT

Committed r183304: <http://trac.webkit.org/changeset/183304>