Bug 144173

Summary:

AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dstockwell, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dean Jackson 2015-04-24 16:39:22 PDT

AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers

Comment 1 Dean Jackson 2015-04-24 16:40:09 PDT

<rdar://problem/20526168>

Comment 2 Dean Jackson 2015-04-24 16:45:56 PDT

Created attachment 251592 [details]
Patch

Comment 3 Simon Fraser (smfr) 2015-04-24 16:49:10 PDT

Comment on attachment 251592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251592&action=review

> Source/WebCore/page/FrameView.cpp:4423
> +        frame().animation().scrollWasUpdated();

Why can't scrollWasUpdated() just early return if !wantsScrollUpdates()?

> Source/WebCore/page/animation/AnimationController.cpp:536
> +    if (!view || m_animationsDependentOnScroll.isEmpty())

Call !wantsScrollUpdates()?

Comment 4 Dean Jackson 2015-04-24 17:12:38 PDT

Committed r183295: <http://trac.webkit.org/changeset/183295>