Bug 144173

Summary: AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dstockwell, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2015-04-24 16:39:22 PDT
AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers
Attachments
Patch (7.51 KB, patch)
2015-04-24 16:45 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-04-24 16:40:09 PDT
<rdar://problem/20526168>
Dean Jackson
Comment 2 2015-04-24 16:45:56 PDT
Created attachment 251592 [details] Patch
Simon Fraser (smfr)
Comment 3 2015-04-24 16:49:10 PDT
Comment on attachment 251592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251592&action=review > Source/WebCore/page/FrameView.cpp:4423 > + frame().animation().scrollWasUpdated(); Why can't scrollWasUpdated() just early return if !wantsScrollUpdates()? > Source/WebCore/page/animation/AnimationController.cpp:536 > + if (!view || m_animationsDependentOnScroll.isEmpty()) Call !wantsScrollUpdates()?
Dean Jackson
Comment 4 2015-04-24 17:12:38 PDT
Committed r183295: <http://trac.webkit.org/changeset/183295>
Note You need to log in before you can comment on or make changes to this bug.