Bug 144173 - AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers
Summary: AnimationController::scrollWasUpdated() shows up in scrolling profiles on pag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-24 16:39 PDT by Dean Jackson
Modified: 2015-04-24 17:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.51 KB, patch)
2015-04-24 16:45 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-04-24 16:39:22 PDT
AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers
Comment 1 Dean Jackson 2015-04-24 16:40:09 PDT
<rdar://problem/20526168>
Comment 2 Dean Jackson 2015-04-24 16:45:56 PDT
Created attachment 251592 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-04-24 16:49:10 PDT
Comment on attachment 251592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251592&action=review

> Source/WebCore/page/FrameView.cpp:4423
> +        frame().animation().scrollWasUpdated();

Why can't scrollWasUpdated() just early return if !wantsScrollUpdates()?

> Source/WebCore/page/animation/AnimationController.cpp:536
> +    if (!view || m_animationsDependentOnScroll.isEmpty())

Call !wantsScrollUpdates()?
Comment 4 Dean Jackson 2015-04-24 17:12:38 PDT
Committed r183295: <http://trac.webkit.org/changeset/183295>