Bug 144172

Summary: TextIndicator for embedded PDFs is slightly offset
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch thorton: review+

Description Brent Fulgham 2015-04-24 16:36:51 PDT 
The Yellow Highlights (TextIndicators) around the word/phrase selected for dictionary lookup, etc., is slightly offset from the layout in PDF.
Comment 1 Brent Fulgham 2015-04-24 16:37:24 PDT 
<rdar://problem/20691304>
Comment 2 Brent Fulgham 2015-04-24 16:59:49 PDT 
Created attachment 251594 [details]
Patch
Comment 3 Tim Horton 2015-04-24 17:01:37 PDT 
Comment on attachment 251594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596
>  

This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore.
Comment 4 Brent Fulgham 2015-04-24 17:03:20 PDT 
Comment on attachment 251594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251594&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:596
>>  
> 
> This function maybe should get a name that isn't about PluginView since it doesn't take one of those anymore.

Well, it takes a PDFPlugin. Maybe I should just drop "PluginView" entirely, since the PDFSelection signifies it's PDF-related.
Comment 5 Brent Fulgham 2015-04-24 17:18:00 PDT 
Committed r183297: <http://trac.webkit.org/changeset/183297>