| Summary: | [Cocoa] Remove users of FontPlatformData's CGFontRef constructor | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Status: | NEW --- | ||||||||||||
| Severity: | Normal | CC: | buildbot, rniwa | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Myles C. Maxfield
2015-04-24 13:50:23 PDT
Created attachment 251569 [details]
Patch
Users of cgFont(): showGlyphsWithAdvances() in FontCascadeCocoa.mm uses it for CGContextShowGlyphsAtPositions() and CGContextShowGlyphsWithAdvances(). CoreText replacement is CTFontDrawGlyphs(). Font::platformWidthForGlyph() uses it for CGFontGetGlyphAdvancesForStyle(). CoreText replacement is CTFontGetAdvancesForGlyphs(). GlyphPage::fill() uses it for CGFontGetGlyphsForUnichars(). CoreText replacement is CTFontGetGlyphsForCharacters() and CTFontGetVerticalGlyphsForCharacters(). Comment on attachment 251569 [details] Patch Attachment 251569 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6271638072983552 Number of test failures exceeded the failure limit. Created attachment 251575 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 251569 [details] Patch Attachment 251569 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5446593109032960 Number of test failures exceeded the failure limit. Created attachment 251578 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 251607 [details]
WIP
Comment on attachment 251607 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=251607&action=review > Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:43 > + CGFloat size = 16; This has got to go. |