Bug 144159

Summary: [Cocoa] Remove users of FontPlatformData's CGFontRef constructor
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: NEW    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
WIP none

Myles C. Maxfield
Reported 2015-04-24 13:50:23 PDT
[Cocoa] Remove users of FontPlatformData's CGFontRef constructor
Attachments
Patch (6.06 KB, patch)
2015-04-24 13:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (759.30 KB, application/zip)
2015-04-24 14:42 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (709.37 KB, application/zip)
2015-04-24 14:58 PDT, Build Bot 		no flags
Details
WIP (6.29 KB, patch)
2015-04-24 20:43 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-04-24 13:54:59 PDT
Created attachment 251569 [details] Patch
Myles C. Maxfield
Comment 2 2015-04-24 14:28:51 PDT
Users of cgFont(): showGlyphsWithAdvances() in FontCascadeCocoa.mm uses it for CGContextShowGlyphsAtPositions() and CGContextShowGlyphsWithAdvances(). CoreText replacement is CTFontDrawGlyphs(). Font::platformWidthForGlyph() uses it for CGFontGetGlyphAdvancesForStyle(). CoreText replacement is CTFontGetAdvancesForGlyphs(). GlyphPage::fill() uses it for CGFontGetGlyphsForUnichars(). CoreText replacement is CTFontGetGlyphsForCharacters() and CTFontGetVerticalGlyphsForCharacters().
Build Bot
Comment 3 2015-04-24 14:42:28 PDT
Comment on attachment 251569 [details] Patch Attachment 251569 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6271638072983552 Number of test failures exceeded the failure limit.
Build Bot
Comment 4 2015-04-24 14:42:31 PDT
Created attachment 251575 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-04-24 14:58:24 PDT
Comment on attachment 251569 [details] Patch Attachment 251569 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5446593109032960 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2015-04-24 14:58:26 PDT
Created attachment 251578 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Myles C. Maxfield
Comment 7 2015-04-24 20:43:00 PDT
Created attachment 251607 [details] WIP
Myles C. Maxfield
Comment 8 2015-04-24 20:43:33 PDT
Comment on attachment 251607 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=251607&action=review > Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:43 > + CGFloat size = 16; This has got to go.
Note You need to log in before you can comment on or make changes to this bug.