Bug 144150

Summary: REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2015-04-24 09:36:45 PDT
There are two issues with this one in WebKit2 and one in InspectorFrontendAPI.js.
Attachments
Patch (3.07 KB, patch)
2015-04-24 09:39 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-04-24 09:37:05 PDT
<rdar://problem/20685861>
Timothy Hatcher
Comment 2 2015-04-24 09:39:40 PDT
Created attachment 251555 [details] Patch
Brian Burg
Comment 3 2015-04-24 10:16:02 PDT
Comment on attachment 251555 [details] Patch r=me It would be great to simplify this code a little, some day.
WebKit Commit Bot
Comment 4 2015-04-24 11:03:42 PDT
Comment on attachment 251555 [details] Patch Clearing flags on attachment: 251555 Committed r183268: <http://trac.webkit.org/changeset/183268>
WebKit Commit Bot
Comment 5 2015-04-24 11:03:47 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2015-04-24 11:45:14 PDT
Comment on attachment 251555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251555&action=review > Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:259 > + evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])")); The ASCIILiteral is not needed here now that we are using makeString(...).
Note You need to log in before you can comment on or make changes to this bug.