Bug 144150

Summary: REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Timothy Hatcher 2015-04-24 09:36:45 PDT 
There are two issues with this one in WebKit2 and one in InspectorFrontendAPI.js.
Comment 1 Radar WebKit Bug Importer 2015-04-24 09:37:05 PDT 
<rdar://problem/20685861>
Comment 2 Timothy Hatcher 2015-04-24 09:39:40 PDT 
Created attachment 251555 [details]
Patch
Comment 3 Brian Burg 2015-04-24 10:16:02 PDT 
Comment on attachment 251555 [details]
Patch

r=me

It would be great to simplify this code a little, some day.
Comment 4 WebKit Commit Bot 2015-04-24 11:03:42 PDT 
Comment on attachment 251555 [details]
Patch

Clearing flags on attachment: 251555

Committed r183268: <http://trac.webkit.org/changeset/183268>
Comment 5 WebKit Commit Bot 2015-04-24 11:03:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2015-04-24 11:45:14 PDT 
Comment on attachment 251555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251555&action=review

> Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:259
> +    evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])"));

The ASCIILiteral is not needed here now that we are using makeString(...).