Bug 144149

Summary: [Mac] Hit testing on <embed> PDFs not working properly
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: PDFAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 143952    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Description Brent Fulgham 2015-04-24 08:41:14 PDT 
Testing has shown that there is a hit testing bug for embedded (<embed>) PDF's. Full page PDFs (at any scale) do work properly.

This can be seen in the TestWebKitAPI 'ActionMenuTest' suite.
Comment 1 Brent Fulgham 2015-04-24 11:06:36 PDT 
<rdar://problem/20677770>
Comment 2 Brent Fulgham 2015-04-24 11:08:09 PDT 
There was an error in the recent PDF positioning calculations I made. I have a local fix, but it is based on the code in Bug 143952.
Comment 3 Brent Fulgham 2015-04-24 13:57:21 PDT 
Created attachment 251570 [details]
Patch
Comment 4 WebKit Commit Bot 2015-04-24 13:59:19 PDT 
Attachment 251570 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:738:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2015-04-24 14:54:54 PDT 
Committed r183282: <http://trac.webkit.org/changeset/183282>