Bug 144134

Summary:

Web Inspector: Speculative fix for non-main thread auto-attach failures

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-04-23 17:55:50 PDT

* SUMMARY
Speculative fix for non-main thread auto-attach failures.

I had suggested we may want to do this in the last patch, but I couldn't come up with a case where it was failing. Though I have heard some reports, so lets just do it anyways.

Comment 1 Radar WebKit Bug Importer 2015-04-23 17:56:23 PDT

<rdar://problem/20678509>

Comment 2 Joseph Pecoraro 2015-04-23 17:56:56 PDT

Created attachment 251517 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2015-04-23 18:08:57 PDT

I believe I just confirmed it with a sample project. Sorry we don't have testing infrastructure for JSContext inspection yet.

Comment 4 WebKit Commit Bot 2015-04-23 21:02:23 PDT

Comment on attachment 251517 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 251517

Committed r183240: <http://trac.webkit.org/changeset/183240>

Comment 5 WebKit Commit Bot 2015-04-23 21:02:28 PDT

All reviewed patches have been landed.  Closing bug.