Bug 144134 - Web Inspector: Speculative fix for non-main thread auto-attach failures
Summary: Web Inspector: Speculative fix for non-main thread auto-attach failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-23 17:55 PDT by Joseph Pecoraro
Modified: 2015-04-23 21:02 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.21 KB, patch)
2015-04-23 17:56 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-23 17:55:50 PDT 
* SUMMARY
Speculative fix for non-main thread auto-attach failures.

I had suggested we may want to do this in the last patch, but I couldn't come up with a case where it was failing. Though I have heard some reports, so lets just do it anyways.
Comment 1 Radar WebKit Bug Importer 2015-04-23 17:56:23 PDT 
<rdar://problem/20678509>
Comment 2 Joseph Pecoraro 2015-04-23 17:56:56 PDT 
Created attachment 251517 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-04-23 18:08:57 PDT 
I believe I just confirmed it with a sample project. Sorry we don't have testing infrastructure for JSContext inspection yet.
Comment 4 WebKit Commit Bot 2015-04-23 21:02:23 PDT 
Comment on attachment 251517 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 251517

Committed r183240: <http://trac.webkit.org/changeset/183240>
Comment 5 WebKit Commit Bot 2015-04-23 21:02:28 PDT 
All reviewed patches have been landed.  Closing bug.