Bug 144113

Summary:

Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2015-04-23 12:27:56 PDT

There is a FIXME in ApplicationCacheFrameTreeElement. We need to fix it for tabs to work.

Comment 1 Timothy Hatcher 2015-04-23 12:28:43 PDT

Created attachment 251467 [details]
Patch

Comment 2 Joseph Pecoraro 2015-04-23 14:10:50 PDT

Comment on attachment 251467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251467&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js:53
> +        while (currentAncestor && !currentAncestor.root) {
> +            if (currentAncestor instanceof WebInspector.ApplicationCacheManifestTreeElement) {

And maybe we should just have a helper for this. TreeElement.prototype.firstAncestorOfType(class). I think this is not the first time we've walked up to find an ancestor via instanceof.

Comment 3 WebKit Commit Bot 2015-04-23 15:01:21 PDT

Comment on attachment 251467 [details]
Patch

Clearing flags on attachment: 251467

Committed r183214: <http://trac.webkit.org/changeset/183214>

Comment 4 WebKit Commit Bot 2015-04-23 15:01:32 PDT

All reviewed patches have been landed.  Closing bug.