Bug 144113 - Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement
Summary: Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-23 12:27 PDT by Timothy Hatcher
Modified: 2015-04-23 15:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2015-04-23 12:28 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-23 12:27:56 PDT 
There is a FIXME in ApplicationCacheFrameTreeElement. We need to fix it for tabs to work.
Comment 1 Timothy Hatcher 2015-04-23 12:28:43 PDT 
Created attachment 251467 [details]
Patch
Comment 2 Joseph Pecoraro 2015-04-23 14:10:50 PDT 
Comment on attachment 251467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251467&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js:53
> +        while (currentAncestor && !currentAncestor.root) {
> +            if (currentAncestor instanceof WebInspector.ApplicationCacheManifestTreeElement) {

And maybe we should just have a helper for this. TreeElement.prototype.firstAncestorOfType(class). I think this is not the first time we've walked up to find an ancestor via instanceof.
Comment 3 WebKit Commit Bot 2015-04-23 15:01:21 PDT 
Comment on attachment 251467 [details]
Patch

Clearing flags on attachment: 251467

Committed r183214: <http://trac.webkit.org/changeset/183214>
Comment 4 WebKit Commit Bot 2015-04-23 15:01:32 PDT 
All reviewed patches have been landed.  Closing bug.